Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Typescript Socket.Io version #1145

Closed
BorntraegerMarc opened this issue Jul 12, 2017 · 5 comments
Closed

Update Typescript Socket.Io version #1145

BorntraegerMarc opened this issue Jul 12, 2017 · 5 comments
Milestone

Comments

@BorntraegerMarc
Copy link

BorntraegerMarc commented Jul 12, 2017

Note: for support questions, please use one of these channels: stackoverflow or slack

You want to:

  • [] report a bug
  • [x ] request a feature

Current behaviour

The version for the typescript version is very old. It's 1.4.4 -> https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/socket.io-client

Steps to reproduce (if the current behaviour is a bug)

Note: the best way to get a quick answer is to provide a failing test case, by forking the following fiddle for example.

Expected behaviour

Update it please to the latest version.

Setup

  • OS: All
  • browser: All
  • socket.io version: latest

Other information (e.g. stacktraces, related issues, suggestions how to fix)

@ghost
Copy link

ghost commented Jan 29, 2020

Is there anyone who handles this issue?

@BorntraegerMarc
Copy link
Author

No. Never had the time to do it :(

There is an open PR that includes some change requests and did some updates. But it never got merged.

DefinitelyTyped/DefinitelyTyped#16619

DefinitelyTyped/DefinitelyTyped#18127

@MickL
Copy link
Contributor

MickL commented Mar 24, 2020

@types/socket.io-client was last updated 4 years ago on version 1.4.32 but latest is 2.3.0 :(

@MickL
Copy link
Contributor

MickL commented Mar 24, 2020

@darrachequesne Could you please update the typings? You are probably the most familiar with all existing functions and types.

@darrachequesne
Copy link
Member

For future readers:

As of Socket.IO v3, the typings are now included in the socket.io-client package.

The types from@types/socket.io-client are not needed anymore and may in fact cause errors like:

Object literal may only specify known properties, and 'extraHeaders' does not exist in type 'ConnectOpts'

@darrachequesne darrachequesne added this to the 3.0.0 milestone Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@MickL @BorntraegerMarc @darrachequesne and others