Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation using apk package fails under Alpine #878

Open
geissebn opened this issue May 31, 2022 · 24 comments
Open

Installation using apk package fails under Alpine #878

geissebn opened this issue May 31, 2022 · 24 comments
Labels
bug build test release improvements to buid, test or release help wanted

Comments

@geissebn
Copy link

What are the steps to reproduce this issue?

  1. Start new Alpine instance (docker run -it alpine:latest)
  2. Follow installation guide at https://git-secret.io/installation#alpine-systems--apk-package

What happens?

apk add --update --no-cache git-secret fails with

WARNING: Ignoring https://gitsecret.jfrog.io/artifactory/git-secret-apk/all/main: package file format error
ERROR: unable to select packages:
  git-secret (no such package):
    required by: world[git-secret]

What were you expecting to happen?

git-secret should install

Any logs, error output, etc?

Complete shell output:

/ # sh -c "echo 'https://gitsecret.jfrog.io/artifactory/git-secret-apk/all/main'" >> /etc/apk/repositor
ies
/ # wget -O /etc/apk/keys/git-secret-apk.rsa.pub 'https://gitsecret.jfrog.io/artifactory/api/security/k
eypair/public/repositories/git-secret-apk'
Connecting to gitsecret.jfrog.io (20.101.176.184:443)
saving to '/etc/apk/keys/git-secret-apk.rsa.pub'
git-secret-apk.rsa.p 100% |*******************************************************|   450  0:00:00 ETA
'/etc/apk/keys/git-secret-apk.rsa.pub' saved
/ # apk add --update --no-cache git-secret
fetch https://dl-cdn.alpinelinux.org/alpine/v3.16/main/x86_64/APKINDEX.tar.gz
fetch https://dl-cdn.alpinelinux.org/alpine/v3.16/community/x86_64/APKINDEX.tar.gz
fetch https://gitsecret.jfrog.io/artifactory/git-secret-apk/all/main/x86_64/APKINDEX.tar.gz
WARNING: Ignoring https://gitsecret.jfrog.io/artifactory/git-secret-apk/all/main: package file format error
ERROR: unable to select packages:
  git-secret (no such package):
    required by: world[git-secret]

Any other comments?

The JFrog repo seems to be broken. https://gitsecret.jfrog.io/artifactory/git-secret-apk/all/main redirects to a login mask

What versions of software are you using?

Operating system: (uname -a) Linux 47766af9ef90 5.10.104-linuxkit #1 SMP Wed Mar 9 19:05:23 UTC 2022 x86_64 Linux

@sobolevn
Copy link
Owner

JFrog 🤦

@geissebn
Copy link
Author

geissebn commented Jun 1, 2022

Well, how can we mitigate this issue?

@sobolevn
Copy link
Owner

sobolevn commented Jun 1, 2022

The only thing I can recommend for now: use source installation.
I am trying to fix JFrog right now.

@sobolevn
Copy link
Owner

sobolevn commented Jun 1, 2022

@sobolevn
Copy link
Owner

sobolevn commented Jun 1, 2022

Hm, this is strange. Looks like we have a different problem:

So, maybe something is change in 15 -> 16 alpine migration?

@sobolevn
Copy link
Owner

sobolevn commented Jun 1, 2022

@joshrabinowitz I think we can try to release 0.5.0 on new alpine releaser.
It might solve this problem 🤔

@joshrabinowitz
Copy link
Collaborator

@sobolevn I approve. Can you perform the release?

@sobolevn
Copy link
Owner

sobolevn commented Jun 1, 2022

Yes, on 2.06 🎉

@joshrabinowitz
Copy link
Collaborator

On 2.06 of what @sobolevn

@joshrabinowitz
Copy link
Collaborator

Should we be filing an issue with jfrog? It seems this is a jfrog issue; can anyone confirm or deny

@sobolevn
Copy link
Owner

sobolevn commented Jun 4, 2022

On 5.06 😞
Don't have any time this week.

@sobolevn
Copy link
Owner

sobolevn commented Jun 5, 2022

New release (0.5.0) is published.
Direct .apk link: https://gitsecret.jfrog.io/artifactory/git-secret-apk/latest-stable/main/x86_64/git-secret-0.5.0.apk

@sobolevn
Copy link
Owner

sobolevn commented Jun 5, 2022

But, it seems that our CI still fails for Alpine 3.16: https://github.com/sobolevn/git-secret/runs/6743924484?check_suite_focus=true#step:3:70

@sobolevn
Copy link
Owner

sobolevn commented Jun 5, 2022

I will contact JFrog, maybe there's something they can do on their side 😞

@joshrabinowitz
Copy link
Collaborator

Any movement on this? I propose we reach out to alpine (or jfrog?) experts for advice about what is going wrong with alpine builds.
See also #881

@sobolevn
Copy link
Owner

sobolevn commented Jun 6, 2022

They literally said: Alpine is bad, do not support it 😢
Imagine my face at that moment.

@joshrabinowitz
Copy link
Collaborator

they being JFrog?

@sobolevn
Copy link
Owner

sobolevn commented Jun 6, 2022

Yeap, support chat

@joshrabinowitz joshrabinowitz added bug help wanted build test release improvements to buid, test or release labels Jun 6, 2022
@joshrabinowitz
Copy link
Collaborator

@sobolevn is there a particular issue are you referring to there?

@joshrabinowitz
Copy link
Collaborator

joshrabinowitz commented Jun 12, 2022

This is also basically a dup/regression of #801 and #802

@joshrabinowitz joshrabinowitz changed the title Installation fails under Alpine Installation using apk package fails under Alpine Jun 12, 2022
@rvanbutselaar
Copy link

Any updates on this, or should we move to Debian / Red Hat based Docker images?

@sobolevn
Copy link
Owner

It does not work :(
https://github.com/sobolevn/git-secret/runs/7047920383?check_suite_focus=true
There's nothing I can do (except finding new Alpine repo host).

@joshrabinowitz
Copy link
Collaborator

joshrabinowitz commented Jun 25, 2022

we recommend you move to source-based installations for Alpine until this is resolved
Edit: You can install 0.5.0 from source using:

git clone -b v0.5.0 https://github.com/sobolevn/git-secret.git git-secret && \
    cd git-secret && make build && \
    PREFIX="/usr/local" make install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug build test release improvements to buid, test or release help wanted
Projects
None yet
Development

No branches or pull requests

4 participants