Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce default concurrency to something more reasonable #3

Closed
soapiestwaffles opened this issue Jan 25, 2022 · 4 comments · Fixed by #22
Closed

reduce default concurrency to something more reasonable #3

soapiestwaffles opened this issue Jan 25, 2022 · 4 comments · Fixed by #22
Assignees
@soapiestwaffles
Labels
enhancement New feature or request
Milestone
1.2.0

Comments

@soapiestwaffles
Copy link
Owner

after testing s3-nuke on a large bucket, I was able to get up to ~8000 objects/sec when I burnt out the AWS rate limit. I figure something more reasonable like 5 concurrency
@soapiestwaffles soapiestwaffles self-assigned this Jan 25, 2022
@soapiestwaffles soapiestwaffles added the enhancement New feature or request label Jan 25, 2022
@soapiestwaffles soapiestwaffles added this to the v1.1.0 milestone Jan 25, 2022
@soapiestwaffles
Copy link
Owner Author

will have to fix #5 first before I can figure out a reasonable amount of concurrency

@soapiestwaffles
Copy link
Owner Author

now that #7 is merged, going to run some tests on this

@soapiestwaffles soapiestwaffles removed this from the v1.1.0 milestone Jan 29, 2022
@soapiestwaffles soapiestwaffles mentioned this issue Feb 11, 2022
Closed
@soapiestwaffles soapiestwaffles added this to the v1.1.2 milestone Feb 11, 2022
@soapiestwaffles soapiestwaffles removed this from the v1.1.2 milestone Mar 18, 2022
@soapiestwaffles soapiestwaffles added this to the 1.2.0 milestone Oct 1, 2022
@mikelorant
Copy link
Contributor

Recommend dropping this from 100 to 5. Anything else is going to cause the rate limiter to kick in very quickly.

@soapiestwaffles
Copy link
Owner Author

agree!

@soapiestwaffles soapiestwaffles mentioned this issue May 16, 2024
Merged
@soapiestwaffles soapiestwaffles linked a pull request May 16, 2024 that will close this issue
Reduce default concurrency limit to 5, down from 100 #22
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soapiestwaffles soapiestwaffles

Labels
enhancement New feature or request
Projects
S3-Nuke
Status: Done
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

Reduce default concurrency limit to 5, down from 100 soapiestwaffles/s3-nuke
2 participants
@mikelorant @soapiestwaffles