Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Snow hooks #3

Open
daniellanner opened this issue Feb 9, 2021 · 1 comment
Open

Adding support for Snow hooks #3

daniellanner opened this issue Feb 9, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@daniellanner
Copy link
Contributor

Similar to git, SnowFS offers a default directory for adding custom hooks to be executed upon calling repository commands. This directory is located at $PROJECTDIR/.snow/hooks.

Typical git hooks are scripts, named and titularly executed as:

  • applypatch-msg
  • commit-msg
  • fsmotir-watchman
  • post-commit
  • post-update
  • pre-applypatch
  • pre-commit
  • pre-merge
  • pre-merge-commit
  • prepare-commit-msg
  • pre-push
  • pre-rebase
  • pre-receive
  • update

Currently these files are not executed when performing the matched action.

At least a subset of the above directives could be implemented to be called when the appropriate action is executed. Example implementations can be existing git hooks.

@daniellanner daniellanner changed the title Snow hooks Adding support for Snow hooks Feb 9, 2021
@sebastianrath sebastianrath added bug Something isn't working enhancement New feature or request good first issue Good for newcomers invalid This doesn't seem right and removed invalid This doesn't seem right bug Something isn't working labels Feb 9, 2021
@sebastianrath
Copy link
Contributor

I just leave the following comments and ideas here. For Unix-based systems, it seems to be a no-brainer to implement it. A platform-independent solution is a little bit more tricky. Things to clarify:

  1. platform-independent she-bang support
  2. I never liked, that Git hooks are not part of the cloning process and must be separately installed.
    If SnowFS will support remote clone/push, I would like to plan ahead for this feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants