Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nit] Be clearer in CONTRIBUTING.md which tox ops are run with tox #1443

Open
ajratner opened this issue Sep 4, 2019 · 3 comments
Open

[Nit] Be clearer in CONTRIBUTING.md which tox ops are run with tox #1443

ajratner opened this issue Sep 4, 2019 · 3 comments
Assignees
Labels
feature request no-stale Auto-stale bot skips this issue

Comments

@ajratner
Copy link
Contributor

ajratner commented Sep 4, 2019

Just a nit: should be clearer e.g. that tox -e complex not run (any others?)

@henryre
Copy link
Member

henryre commented Sep 4, 2019

This is covered in https://github.com/snorkel-team/snorkel/blob/master/CONTRIBUTING.md#complexintegrationlong-running-tests, but we can also add indicators for the commands in the block here (https://github.com/snorkel-team/snorkel/blob/master/CONTRIBUTING.md#testing-and-committing) as to whether they're run with tox and/or by Travis. That work?

@github-actions
Copy link

github-actions bot commented Oct 5, 2019

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions
Copy link

github-actions bot commented Nov 8, 2019

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@vincentschen vincentschen added the no-stale Auto-stale bot skips this issue label Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request no-stale Auto-stale bot skips this issue
Projects
None yet
Development

No branches or pull requests

3 participants