Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change LF stat "empirical accuracy" to "precision" #1435

Open
astarostap opened this issue Aug 27, 2019 · 2 comments
Open

Change LF stat "empirical accuracy" to "precision" #1435

astarostap opened this issue Aug 27, 2019 · 2 comments
Assignees
Labels
bug no-stale Auto-stale bot skips this issue

Comments

@astarostap
Copy link

I was using Metal's LF analysis function, which gives you the "empirical accuracy" of your LFs. It was pretty confusing, I wasn't sure if it was computing its accuracy or its precision. After some experimentation I realized it's computing rule precisions. So, I thought maybe it would be better to call it "precision" to avoid confusions.

@ajratner ajratner self-assigned this Aug 31, 2019
@ajratner ajratner added the bug label Aug 31, 2019
@ajratner
Copy link
Contributor

@astarostap thanks for pointing this out! We need to make sure our naming is clear here. As you pointed out, in all but the simplest label model configurations, 'accuracy' is a misnomer. More precisely, the weights are the estimated conditional probabilities. I think this is clear in the label model now but not necessarily all helper functions throughout the repo... we'll do a cleaning pass here!

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug no-stale Auto-stale bot skips this issue
Projects
None yet
Development

No branches or pull requests

3 participants