the error:Skipping key

[cjhlai]

@ snmaynard
Hi, When I go to run redis-audit.rb
I get the following result:
[root@6-3 redis-audit]# bundle exec ruby redis-audit.rb -h 192.168.0.9 -p 8000 -d 0 -s 20
Auditing 192.168.0.9:8000 dbnum:0 sampling 20 keys
Sampling 20 keys...
Skipping key o2o.service.common.cache.prefix.v1employee.count.org.all.v13.15427
Skipping key o2o.service.common.cache.prefix.v3employee.count.org.all.v13.14036
2 keys sampled - 10% complete - Wed Jul 26 20:28:39 +0800 2017
Skipping key o2o.service.common.cache.prefix.v3employee.count.org.all.v13.7054
Skipping key post.id.list.30039684
4 keys sampled - 20% complete - Wed Jul 26 20:28:39 +0800 2017
Skipping key user.daily.3000069020170606
Skipping key o2o.service.common.cache.prefix.v1employee.count.org.all.v13.18364
6 keys sampled - 30% complete - Wed Jul 26 20:28:39 +0800 2017
Skipping key o2o.service.common.cache.prefix.v3employee.count.org.all.v25.16556
Skipping key o2o.service.common.cache.prefix.v3employee.count.org.all.v13.16948
8 keys sampled - 40% complete - Wed Jul 26 20:28:39 +0800 2017
Skipping key o2o.service.common.cache.prefix.v3employee.count.org.all.v25.20019
Skipping key post.id.list.30044754
10 keys sampled - 50% complete - Wed Jul 26 20:28:39 +0800 2017
Skipping key thread.count.30025128
Skipping key o2o.service.common.cache.prefix.v3employee.detail.v13.179
12 keys sampled - 60% complete - Wed Jul 26 20:28:39 +0800 2017
Skipping key o2o.service.common.cache.prefix.v2employee.count.org.all.v22.22981
Skipping key o2o.service.common.cache.prefix.v3employee.count.org.all.v25.13945
14 keys sampled - 70% complete - Wed Jul 26 20:28:39 +0800 2017
Skipping key o2o.service.common.cache.prefix.v1v11org.byid22190
Skipping key o2o.service.common.cache.prefix.v1employee.count.org.all.v13.13914
16 keys sampled - 80% complete - Wed Jul 26 20:28:39 +0800 2017
Skipping key o2o.service.common.cache.prefix.v2employee.count.org.all.v13.19762
Skipping key o2o.service.common.cache.prefix.v2employee.count.org.all.v13.20081
18 keys sampled - 90% complete - Wed Jul 26 20:28:39 +0800 2017
Skipping key user.daily.2000058220170627
Skipping key o2o.service.common.cache.prefix.v3employee.count.org.all.v26.5233
20 keys sampled - 100% complete - Wed Jul 26 20:28:39 +0800 2017
DB has 82587 keys
Sampled 0 bytes of Redis memory

Found 0 key groups

==============================================================================
Summary

---------------------------------------------------+--------------+-------------------+---------------------------------------------------
Key | Memory Usage | Expiry Proportion | Last Access Time
---------------------------------------------------+--------------+-------------------+---------------------------------------------------
---------------------------------------------------+--------------+-------------------+---------------------------------------------------

[awittig]

This happens for me when I try to run redis-audit against a slave node in a cluster. Running it against a master node works.

[maxp-hover]

If you look in the source code:

  rescue Redis::CommandError
    $stderr.puts "Skipping key #{key}"
  end

It's printing this method every time there is an error (and hiding the error). I don't believe this is the way it should be done. It should alert the user about the error and let them handle it.