Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant constraints for MonadSnap #248

Open
treeowl opened this issue Nov 18, 2015 · 2 comments
Open

Redundant constraints for MonadSnap #248

treeowl opened this issue Nov 18, 2015 · 2 comments

Comments

@treeowl
Copy link

treeowl commented Nov 18, 2015

Currently,

class (Monad m, MonadIO m, MonadCatchIO m, MonadPlus m, Functor m, Applicative m, Alternative m) => MonadSnap m

For GHC before 7.10, that should be

class (MonadCatchIO m, MonadPlus m, Alternative m) => MonadSnap m

For GHC 7.10 and later, it should be

class (MonadCatchIO m, MonadPlus m) => MonadSnap m

Note also that the package snap-core gets MonadCatchIO from is marked obsolete; it's been replaced by another.

@gregorycollins
Copy link
Member

Is that a problem? I don't think it warns, does it? I actually prefer the expanded list for didactic reasons.

Re: MonadCatchIO, we're not using it in 1.0 (which is getting close to being released).

@treeowl
Copy link
Author

treeowl commented Nov 18, 2015

I'm not sure if it warns with -Wall or not. It's mostly a lot to dig through to figure out the essence of what it means. And it looks ugly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants