Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automatically rerun jobs if parameters, code, input file set, or software stack changed (thanks to @cclienty and @timtroendle). This also increases performance of DAG building by handling job "needrun" updates level wise, while avoiding to perform a full check for those jobs that are already downstream of a job that has been determined to require a rerun. #1663

Merged
merged 12 commits into from May 24, 2022

Conversation

johanneskoester
Copy link
Contributor

@johanneskoester johanneskoester commented May 17, 2022

Description

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@johanneskoester johanneskoester changed the title feat: automatically rerun jobs if parameters, code, input file set, or software stack changed feat: automatically rerun jobs if parameters, code, input file set, or software stack changed (thanks to @cclienty and @timtroendle) May 18, 2022
@sonarcloud
Copy link

sonarcloud bot commented May 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanneskoester johanneskoester changed the title feat: automatically rerun jobs if parameters, code, input file set, or software stack changed (thanks to @cclienty and @timtroendle) feat: automatically rerun jobs if parameters, code, input file set, or software stack changed (thanks to @cclienty and @timtroendle). This also increases performance of DAG building by handling job "needrun" updates level wise, while avoiding to perform a full check for those jobs that are already downstream of a job that has been determined to require a rerun. May 24, 2022
@johanneskoester johanneskoester merged commit 4c11893 into main May 24, 2022
@johanneskoester johanneskoester deleted the feat/rerun-on-all-changes branch May 24, 2022 08:14
@hermidalc
Copy link

This feature does not completely work with checkpoints, there is a major issue or regression #1818

@hermidalc
Copy link

I've tested the #1818 simple example with 7.15.1 (latest avail on bioconda) and still it re-runs all the rules downstream of a checkpoint that just ran and created all the files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants