fix: update for minimum of Python 3.7 #1509
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tl;dr As of fd5daae, snakemake requires Python 3.7. This PR updates any reference to previous versions
I came to the GitHub repo to determine the minimum required Python version to run Snakemake, and I quickly got confused. The README displays Python 3.5:
But
setup.py
clearly requires Python 3.7+snakemake/setup.py
Lines 14 to 16 in 5f7170e
I was going to simply update the metadata
snakemake/setup.py
Line 109 in 5f7170e
But I saw in commit 0357911 that the minimum required version is specified in multiple other places. This PR is my attempt to update the code and tests to remove any reference to Python versions < 3.7.
A few other notes:
QC
I don't think this PR requires additional tests or documentation. Please let me know if there is more you'd like me to do.
docs/
) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).