feat: Adding --cluster-cancel and --cluster-cancel-nargs #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanneskoester
changed the title
johanneskoester
requested changes
Feb 14, 2022
holtgrewe
force-pushed
the
cluster-cancel
branch
2 times, most recently
from
5d739a4
to
a8bbbdf
Compare
|
Sorry for the many pushes but I had a hard time uncovering why the CI was failing and it was running locally (as so often, timing issues because of fewer cores in CI than in dev). I'm positive that this is ready for re-review 👓 🔍 🔬 |
holtgrewe
force-pushed
the
cluster-cancel
branch
2 times, most recently
from
dc9a871
to
be21d73
Compare
holtgrewe
force-pushed
the
cluster-cancel
branch
from
be21d73
to
39dab77
Compare
|
🎉 |
holtgrewe
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
johanneskoester
approved these changes
Feb 17, 2022
johanneskoester
added a commit
that referenced
this pull request
Feb 18, 2022
* Remove the decode attributes of source files fix #1393 * Adding a test with report generation without md5sum check * Formatting with black * feat: Adding --cluster-cancel and --cluster-cancel-nargs (#1395) * Adding support for --cluster-[m]cancel * Adding support for --cluster-[m]cancel. * Adressing points from code review * [ci skip] fix typos Co-authored-by: Johannes Köster <johannes.koester@uni-due.de> Co-authored-by: Johannes Köster <johannes.koester@tu-dortmund.de> Co-authored-by: Manuel Holtgrewe <manuel.holtgrewe@bihealth.de> Co-authored-by: Johannes Köster <johannes.koester@uni-due.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the optional arguments
--cluster-canceland--cluster-mcancel. The user can specify commands for terminating jobs by their job ID, either one at a time (--cluster-cancel) or multiple at once (--cluster-mcancel). Testing this was somewhat tricky because you have to simulate sentingSIGINTto the job so I ended extendingtests/common.pya bit.QC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities ofAddresses: #570