Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consider post-deploy script for env hashing #1363

Merged
merged 9 commits into from Jan 31, 2022

Conversation

FelixMoelder
Copy link
Contributor

Description

When including post-deploy scripts the environment hash will not take the scripts into account.
In case different rules have conda environment files with identical content but different (or non) post-deploy scripts they will activate the same environment based on the env file content.
To fix this the hash of each environment will now also include the content of post-deploy scripts.

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@sonarcloud
Copy link

sonarcloud bot commented Jan 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanneskoester johanneskoester merged commit d50efd9 into main Jan 31, 2022
@johanneskoester johanneskoester deleted the fix_postdeploy_hashing branch January 31, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants