New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid mutable default argument #1330

Merged

johanneskoester merged 1 commit into snakemake:main from kazanzhy:fix_default_mutable_argument

Feb 5, 2022

Contributor

kazanzhy commented Jan 12, 2022 •

edited

Description

It is considered to be an antipattern the usage of mutable types as a default argument of the function.
https://docs.quantifiedcode.com/python-anti-patterns/correctness/mutable_default_value_as_argument.html

QC

The PR contains a test case for the changes or the changes are already covered by an existing test case.
The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).


          Fixed mutable default argument

4ce5479

kazanzhy requested a review from johanneskoester as a code owner

January 12, 2022 21:48

sonarcloud bot commented Jan 12, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

johanneskoester approved these changes

View reviewed changes

johanneskoester changed the title ~~Fixed mutable default argument~~ fix: avoid mutable default argument

johanneskoester merged commit 978cc93 into snakemake:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment