fix: issue with duplicated prefix for checkpoints on cloud #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to reproduce a problem with the use of checkpoints in cloud environments
|
Kudos, SonarCloud Quality Gate passed!
|
2 tasks
|
nice! it looks like the test failed properly I should have some time in the coming weeks to try some fixes. |
|
Thanks a lot for giving this a try!! |
|
Kudos, SonarCloud Quality Gate passed!
|
aryarm
changed the title
|
@johanneskoester, the tests passed. It's ready for you to take a look! #574 (comment) has a description of the bug and the solution that I implemented. |
johanneskoester
approved these changes
Feb 21, 2022
|
Thanks a lot for fixing this long standing bug! |
This was referenced Feb 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a test to reproduce issue #574: checkpoints in cloud execution mode.
Note: this PR duplicates #1199.
Once I'm able to reproduce the issue, I'm planning on using this PR to fix it.
Update (1/14/22): This PR now also resolves #574
See #574 (comment) for a description of the bug and the solution that I implemented.
QC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).