Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: LockException #1276

Merged
merged 12 commits into from May 10, 2022
Merged

feat: LockException #1276

merged 12 commits into from May 10, 2022

Conversation

Maarten-vd-Sande
Copy link
Contributor

@Maarten-vd-Sande Maarten-vd-Sande commented Nov 24, 2021 •
edited

Description

Stub for this PR. Let me know if this is something you will/won't support 馃槃

I'm using the API, and I am trying to catch the case where snakemake can not lock the directory. However since no exception is called it gets hard to catch that.

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@Maarten-vd-Sande Maarten-vd-Sande changed the title add LockException feat: LockException Nov 24, 2021
@Maarten-vd-Sande Maarten-vd-Sande mentioned this pull request Nov 25, 2021
Merged
4 tasks
@johanneskoester
Copy link
Contributor

Sure, no objections. Thanks for looking into that!

@sonarcloud
Copy link

sonarcloud bot commented Nov 28, 2021

Kudos, SonarCloud Quality Gate passed!聽 聽 Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Maarten-vd-Sande
Copy link
Contributor Author

@johanneskoester I'm not sure where I should add the test. I'm pretty sure the testapi.py file is wrong, but I couldn't really figure out where else it would make sense

@sonarcloud
Copy link

sonarcloud bot commented Jan 4, 2022

Kudos, SonarCloud Quality Gate passed!聽 聽 Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Feb 19, 2022

Kudos, SonarCloud Quality Gate passed!聽 聽 Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented May 10, 2022

Kudos, SonarCloud Quality Gate passed!聽 聽 Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

@johanneskoester johanneskoester merged commit f5e6fa6 into snakemake:main May 10, 2022
LarsStegemanGT pushed a commit to LarsStegemanGT/snakemake that referenced this pull request Jan 16, 2023
@Maarten-vd-Sande @johanneskoester @LarsStegemanGT
feat: LockException (snakemake#1276)
7914225 
* add LockException

* add tests

* try older mamba

Co-authored-by: Johannes K枚ster <johannes.koester@tu-dortmund.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanneskoester johanneskoester johanneskoester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Maarten-vd-Sande @johanneskoester