fix: SameFileError #1153

[stydodt]

Description

Pull request to fix bug #1153.

When relative paths were provided to rules with the --generate-unit-tests flag the target path and the tests were successfully created. However, when full paths were used, the automatic unittest generation failed. This was caused by behavior of the Path.parent() property. As path and f.parent are matching this leads to f and target matching and the SameFileError raised by shutils.

Behaviour of Path.parent:

>>> from pathlib import Path
>>> f = Path("/dummy/test/path")
>>> f.parent
PosixPath('/dummy/test')
>>> path = Path("/dummy/test/path/")
>>> rulename = "test"
>>> content_type = "expected"
>>> target = path / rulename / content_type / f.parent
>>> target
PosixPath('/dummy/test')

Removing f.parent creates a successful, matching folder structure with both relative and full paths and allows unittests to be generated.

QC

• The PR contains a test case for the changes or the changes are already covered by an existing test case.
• The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[johanneskoester]

The tests seem to fail now, can you have a look?

[stydodt]

Sorry for the delay - I did not get a notification from Github about activity. Thanks for running the pipeline. I must have set my local environment incorrectly as I didn't spot this when I ran the tests - I will investigate.

EDIT: I can now recreate this error locally.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[stydodt]

Thanks for finishing and merging this @johanneskoester ! Getting the tests working was proving challenging given the time constraints and being new to the codebase.