fix: status cmd repeats until killed by 11 *different* signals #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm pretty sure this wasn't meant to only abort if the status cmd was killed by more than 10 *different* signals.
epruesse
changed the title
johanneskoester
approved these changes
Oct 11, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
pvandyken
pushed a commit
to pvandyken/snakemake
that referenced
this pull request
Nov 15, 2021
…make#1207) * Count times status_cmd killed by same signal I'm pretty sure this wasn't meant to only abort if the status cmd was killed by more than 10 *different* signals. * fix typo (yes, "extend" and "append" are right next to each other) Co-authored-by: Johannes Köster <johannes.koester@uni-due.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm pretty sure the code wasn't intended to only abort if the status cmd was killed by more than 10 different signals.
Description
QC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).