feat: Add more informative errors when evaluation of --default-resources fails
#1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonFreed
changed the title
--default-resources fails--default-resources fails
|
I'm not sure why the tests took so long here? |
johanneskoester
requested changes
Sep 29, 2021
|
It looks like there may have been some DNS issues at Quay during testing, https://status.quay.io/incidents/bt8yqm82069z |
|
Kudos, SonarCloud Quality Gate passed!
|
johanneskoester
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
--default-resourcesvalues are evaluated witheval()and some default resources strings can fail if not properly quoted (e.g. see #1093). This PR adds a more informative error message for--default-resourcesarguments that raise an exception.QC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).