fix: wms monitor arg ints #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
Thanks a lot @Tobias-Ternent . I just tested the changes and it works fine for me. @vsoch I think it would be great to have your input and make sure that no breaking changes are introduced for snakeface. |
vsoch
approved these changes
Sep 17, 2021
|
@johanneskoester It would be great if you can include this fix for the next release. |
johanneskoester
approved these changes
Oct 21, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
pvandyken
pushed a commit
to pvandyken/snakemake
that referenced
this pull request
Nov 15, 2021
…#1181) * Fixes snakemake#1180. No longer casting WMS args as integers. * Fixes snakemake#1180. Removing unused parse_resources() import. * Fixing WMS args parsing. * Removed unused imports. Co-authored-by: terneto1 <tobias.ternent@novartis.com> Co-authored-by: Johannes Köster <johannes.koester@uni-due.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing an issue I was experiencing when passing in wms-monitor-arg values, it was casting everything to integers, and I want to be able to pass in other things like Strings. So just removing usage of the parse_resources() in the WMS logger.
QC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).