New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: async_run to allow nested event loops. #1170

Merged

johanneskoester merged 2 commits into snakemake:main from ashwinvis:fix/asyncio-run

Sep 24, 2021

Contributor

ashwinvis commented Sep 10, 2021 •

edited

Fixes: #1105

Description

QC

The PR contains a test case for the changes or the changes are already covered by an existing test case.
The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).


          Fix async_run to allow nested event loops.

aafad37

Fixes: snakemake#1105

ashwinvis requested a review from johanneskoester as a code owner

September 10, 2021 09:09

ashwinvis changed the title ~~Fix async_run to allow nested event loops.~~ fix: async_run to allow nested event loops.


          Use standard asyncio.run in outer loop for tests

4b630f7

sonarcloud bot commented Sep 13, 2021

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

johanneskoester approved these changes

View reviewed changes

Contributor

johanneskoester commented Sep 24, 2021

Thanks a lot!

johanneskoester merged commit 5dc6bbd into snakemake:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment