Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement support for removing GFAL remote files #1103

Merged
merged 4 commits into from Jan 26, 2022
Merged

feat: implement support for removing GFAL remote files #1103

merged 4 commits into from Jan 26, 2022

Conversation

cailmdaley
Copy link
Contributor

Description

Currently, gfal remote files cannot be deleted/updated:

NotImplementedError: Removal of files is unavailable for this remote

This PR defines one-line remove() method for the gfal RemoteObject.

@sonarcloud
Copy link

sonarcloud bot commented Jul 22, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@johanneskoester johanneskoester changed the title add gfal RemoteObject.remove() method feat: add gfal RemoteObject.remove() method Oct 26, 2021
@johanneskoester johanneskoester changed the title feat: add gfal RemoteObject.remove() method feat: implement support for removing GFAL remote files Oct 26, 2021
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

johanneskoester
johanneskoester approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@johanneskoester johanneskoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cailmdaley
Copy link
Contributor Author

Thank you as well @johanneskoester! Is there anything else that needs to be done before this is merged?

@johanneskoester
Copy link
Contributor

Nope, sorry, I am just slow with this.

@sonarcloud
Copy link

sonarcloud bot commented Jan 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@johanneskoester johanneskoester merged commit 25943e5 into snakemake:main Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanneskoester johanneskoester johanneskoester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cailmdaley @johanneskoester