Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support XRootD as a default remote provider #1017

Merged
merged 9 commits into from Aug 17, 2021
Merged

feat: support XRootD as a default remote provider #1017

merged 9 commits into from Aug 17, 2021

Conversation

ryuwd
Copy link
Contributor

@ryuwd ryuwd commented May 26, 2021 •
edited

Description

It is currently not possible to specify --default-remote-provider=XRootD on the command line, and by extension when using a snakemake profile that uses XRootD remote storage.

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@ryuwd ryuwd marked this pull request as draft May 26, 2021 18:08
@ryuwd ryuwd changed the title Fix: Add missing remote provider XRootD to the list of allowed default remote providers Add missing remote provider XRootD to the list of allowed default remote providers May 26, 2021
@ryuwd ryuwd changed the title Add missing remote provider XRootD to the list of allowed default remote providers Support XRootD as a default remote provider May 26, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jun 4, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ryuwd
Copy link
Contributor Author

ryuwd commented Jun 4, 2021 •
edited

@chrisburr since you are the original author of the XRootD remote provider, do you have any thoughts on this?

I initially started work on this to see if I could use this for running snakemake workflows at the CERN grid site, but have since started writing a remote file provider for Dirac instead.

Do you think this change would be useful? (and does my meddling with the paths break anything?)

Edit: I have tested on lxplus to see if it works with LHCb EOS and it seems to work fine to me.

johanneskoester
johanneskoester approved these changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@johanneskoester johanneskoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me, this looks good.

@johanneskoester
Copy link
Contributor

@chrisburr do you want to give this is final look?

@johanneskoester johanneskoester changed the title Support XRootD as a default remote provider feat: support XRootD as a default remote provider Aug 12, 2021
@johanneskoester johanneskoester marked this pull request as ready for review August 12, 2021 10:18
@sonarcloud
Copy link

sonarcloud bot commented Aug 12, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanneskoester johanneskoester merged commit fe03157 into snakemake:main Aug 17, 2021
@chaen chaen mentioned this pull request Jan 24, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanneskoester johanneskoester johanneskoester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ryuwd @johanneskoester