Protects against spaces in env vars and avoid quoting of all env vars as single entity #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as single entity.
|
Kudos, SonarCloud Quality Gate passed!
|
johanneskoester
requested changes
Jun 28, 2021
| @@ -792,13 +792,15 @@ def write_jobscript(self, job, jobscript, **kwargs): | |||
| use_threads = "--force-use-threads" if not job.is_group() else "" | |||
|
|
|||
| envvars = " ".join( | |||
| "{}={}".format(var, os.environ[var]) for var in self.workflow.envvars | |||
| # quotes values, as envvars values could have spaces | |||
| "{}='{}'".format(var, os.environ[var]) | |||
There was a problem hiding this comment.
What if the env var itself contains single quotes? Python provides escape mechanisms that should be used instead: use repr(os.environ[var]).
| ) | ||
|
|
||
| exec_job = self.format_job( | ||
| self.exec_job, | ||
| job, | ||
| _quote_all=True, | ||
| _quote_all=False, |
There was a problem hiding this comment.
Are you sure this has to be deactivated? It is also needed for other things in the exec job template.
2 tasks
|
Closing in favor of a global solution in #1491. Nevertheless, thanks a lot for taking a first stab at this! |
johanneskoester
added a commit
that referenced
this pull request
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1007