Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
fix: status cmd repeats until killed by 11 *different* signals (#1207)
* Count times status_cmd killed by same signal

I'm pretty sure this wasn't meant to only abort if the status cmd was killed by more than 10 *different* signals.

* fix typo (yes, "extend" and "append" are right next to each other)

Co-authored-by: Johannes Köster <johannes.koester@uni-due.de>
  • Loading branch information
epruesse and johanneskoester committed Oct 21, 2021
1 parent 1d79f62 commit 8b28b57
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions snakemake/executors/__init__.py
Expand Up @@ -1073,7 +1073,7 @@ def _wait_for_jobs(self):
success = "success"
failed = "failed"
running = "running"
status_cmd_kills = set()
status_cmd_kills = []
if self.statuscmd is not None:

def job_status(job, valid_returns=["running", "success", "failed"]):
Expand All @@ -1093,7 +1093,7 @@ def job_status(job, valid_returns=["running", "success", "failed"]):
# snakemake.
# Snakemake will handle the signal in
# the main process.
status_cmd_kills.add(e.returncode)
status_cmd_kills.append(-e.returncode)
if len(status_cmd_kills) > 10:
logger.info(
"Cluster status command {} was killed >10 times with signal(s) {} "
Expand Down

0 comments on commit 8b28b57

Please sign in to comment.