Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
fix: issue1460 intermediate files existing (or not) (#1541)
* chore: add testcase for issue #1460 * fix expected results * try force update of inventory after upload Signed-off-by: vsoch <vsoch@users.noreply.github.com> * run gls tests first Signed-off-by: vsoch <vsoch@users.noreply.github.com> * pushing test fix the issue is that the blob object held by a GS remote object can go sort of stale, returning a False for blob.exists() when it clearly exists! To fix we need to do an additional self.update_blob() and then returning the exists check again. I am not sure if this can be made more efficient by only checking under certain conditions, but since it seems likely we cannot perfectly know when the blob has gone stale the sure way is to always update. Signed-off-by: vsoch <vsoch@users.noreply.github.com> * wrong version of black Signed-off-by: vsoch <vsoch@users.noreply.github.com> * remove unused remote inventory, was just testing! Signed-off-by: vsoch <vsoch@users.noreply.github.com> Co-authored-by: Johannes Köster <johannes.koester@tu-dortmund.de> Co-authored-by: vsoch <vsoch@users.noreply.github.com>
- Loading branch information
1 parent
1112321
commit 1b3ede1
Showing
9 changed files
with
141 additions
and
46 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
rule all: | ||
input: | ||
"blob.txt", | ||
"test.txt" | ||
|
||
|
||
rule intermediate: | ||
input: | ||
"preblob.txt", | ||
"pretest.txt", | ||
output: | ||
"blob.txt", | ||
"test.txt", | ||
shell: | ||
""" | ||
cp {input[0]} {output[0]} | ||
cp {input[1]} {output[1]} | ||
""" | ||
|
||
|
||
rule create: | ||
output: | ||
"preblob.txt", | ||
"pretest.txt" | ||
shell: | ||
''' | ||
echo "test file" > {output[0]} | ||
echo "test file" > {output[1]} | ||
''' |
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters