Skip to content

Commit

Permalink
fix: display change warnings only for jobs that won't be executed oth…
Browse files Browse the repository at this point in the history
…erwise
  • Loading branch information
johanneskoester committed Mar 4, 2022
1 parent 1858bb9 commit 086f60f
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions snakemake/dag.py
Expand Up @@ -2235,10 +2235,10 @@ def stats(self):
yield tabulate(rows, headers="keys")
yield ""

def get_outputs_with_changes(self, change_type):
def get_outputs_with_changes(self, change_type, include_needrun=True):
is_changed = lambda job: (
getattr(self.workflow.persistence, f"{change_type}_changed")(job)
if not job.is_group()
if not job.is_group() and (include_needrun or not self.needrun(job))
else []
)
changed = list(chain(*map(is_changed, self.jobs)))
Expand All @@ -2251,7 +2251,9 @@ def get_outputs_with_changes(self, change_type):
def warn_about_changes(self, quiet=False):
if not quiet:
for change_type in ["code", "input", "params"]:
changed = self.get_outputs_with_changes(change_type)
changed = self.get_outputs_with_changes(
change_type, include_needrun=False
)
if changed:
rerun_trigger = ""
if not ON_WINDOWS:
Expand Down

0 comments on commit 086f60f

Please sign in to comment.