Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Calculate damage for Pain Split #572

Open
jmynes opened this issue Aug 3, 2023 · 2 comments
Open

Feat: Calculate damage for Pain Split #572

jmynes opened this issue Aug 3, 2023 · 2 comments

Comments

@jmynes
Copy link

jmynes commented Aug 3, 2023

Is it possible to add Pain Split calculation?
It would be great to quickly see if I will heal or deal damage in any particular battle state, without having to manually do the math.

I'm not sure how this well fits in the official calculator's UI, but if damage healed/dealt were queryable, it would be easier to add to other software which queries this package.


If it were to fit into the existing UI, I would guess the best option is to put healing % on the left of the -, and dmg on the right, maybe with color coding, or a dotted underline indicating a tooltip?

@ForwardFeed
Copy link

Winning HP:
image
Losing HP:
image

I managed to render this kind of results, if people feels its right so, i'll do a PR

@thejetou
Copy link
Collaborator

Winning HP: image Losing HP: image

I managed to render this kind of results, if people feels its right so, i'll do a PR

Yeah, feel free to PR it. We can look over the details there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants