Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes made for travis CI break up developing this gem #12

Open
wafcio opened this issue Oct 1, 2016 · 6 comments
Open

Changes made for travis CI break up developing this gem #12

wafcio opened this issue Oct 1, 2016 · 6 comments

Comments

@wafcio
Copy link
Contributor

wafcio commented Oct 1, 2016

@smcabrera a few things connected with yout changes for travis:

  • .ruby-version file isn't necesary if you defined rvm section. Ruby 2.2.4 is little old, there should be defined more ruby version for travis.
  • freezing bundler version in gemspec isn't so good, because with newer bundler version it is impossible to ruby bundle command. I think taht it can be achieved in different way for Travis CI
@smcabrera
Copy link
Owner

Ah thanks for pointing that out. The reason I included bundler as a dependency is that CI was failing, maybe if I use a more recent version of ruby that won't happen?

@wafcio
Copy link
Contributor Author

wafcio commented Oct 2, 2016

Everytime freezing bundler on specific version is wrong, because each time after new bundler is released then you must update repo, which isn't good. There must be better solution.

@smcabrera
Copy link
Owner

@wafcio I think the latest commit should fix this issue.

@wafcio
Copy link
Contributor Author

wafcio commented Oct 2, 2016

@smcabrera You added .ruby-version to .gitignore, but you didn't remove it from repo.

@smcabrera
Copy link
Owner

Ah good catch, thanks

@wafcio
Copy link
Contributor Author

wafcio commented Oct 9, 2016

In gemspec you froze bundler version which is old right now. I tried to use old bundler version but all time it use the newest version in my system. I think it should be removed from gemspec too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants