Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node: Mutex Guard Dispatcher Sub List #55

Closed
AnnsAnns opened this issue May 2, 2024 · 1 comment
Closed

Node: Mutex Guard Dispatcher Sub List #55

AnnsAnns opened this issue May 2, 2024 · 1 comment
Labels
Node Team This issue belongs to the Node team

Comments

@AnnsAnns
Copy link
Member

AnnsAnns commented May 2, 2024

Currently (in theory) two threads could ask the dispatcher to be subscribed to a new event at the same time and cause chaos. In reality this will probably not happen, esp. since normally subscriptions only happen in the main thread but it'd still make sense to properly guard the list.
@AnnsAnns AnnsAnns added the Node Team This issue belongs to the Node team label May 2, 2024
@moritzholzer
Copy link
Contributor

no dispatcher anymore, so we dont need this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Node Team This issue belongs to the Node team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AnnsAnns @moritzholzer