Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permission Manager notified too often of permission changes #965

Closed
joeljfischer opened this issue May 16, 2018 · 0 comments
Closed

Permission Manager notified too often of permission changes #965

joeljfischer opened this issue May 16, 2018 · 0 comments
Assignees
Labels
bug A defect in the library
Projects
Milestone

Comments

@joeljfischer
Copy link
Contributor

joeljfischer commented May 16, 2018

See #957

Bug Report

Subscribers to permission changes will be notified unnecessarily if the new permissions for a subscribed RPC are exactly the same when an OnPermissionsChange notification is received. The sdl_filterPermissionChangesForFilters only checks for the rpcName and not the hmiPermissions and parameterPermissions.

When the OnPermissionsChange notification is sent, it includes all of the supported RPCs, not just the RPCs whose permissions changed. If the permissions for an RPC did not change, the observer will still be notified. This is because the permission manager assumes that the notification will only include the RPCs whose permissions changed.

This seems likely to be a Core bug.

Reproduction Steps
  1. [Step 1]
  2. [Step 2]
  3. [Step 3]
Expected Behavior

[Some expected behavior]

Observed Behavior

[Some observed behavior]

OS & Version Information
  • iOS Version: n/a
  • SDL iOS Version: v5.2
  • Testing Against: [Ford] Sync Gen 3
@joeljfischer joeljfischer added the bug A defect in the library label May 16, 2018
@joeljfischer joeljfischer added this to the 6.1.0 milestone May 16, 2018
@joeljfischer joeljfischer modified the milestones: 6.1.0, Future Jul 24, 2018
@NicoleYarroch NicoleYarroch added this to To do in v6.4 via automation Jul 30, 2019
@NicoleYarroch NicoleYarroch modified the milestones: Future, 6.4.0 Jul 30, 2019
v6.4 automation moved this from To do to Done Jul 30, 2019
@joeljfischer joeljfischer mentioned this issue Oct 24, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library
Projects
No open projects
v6.4
  
Done
Development

No branches or pull requests

2 participants