Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Computed properties should not be retained using object association #69

Closed
justinjdickow opened this issue Feb 5, 2015 · 1 comment
Closed

Computed properties should not be retained using object association #69

justinjdickow opened this issue Feb 5, 2015 · 1 comment
Labels
best practice Not a defect but something that should be improved anyway

Comments

@justinjdickow
Copy link
Contributor

Especially in the case of the putFileRPCRequest, which is already retained as an object association by the inputStream.

The only time this property is retrieved is in the proxy's [stream:handleEvent] method, which has access to the putFileRPCRequest which computes the property.
@justinjdickow justinjdickow added the best practice Not a defect but something that should be improved anyway label Feb 5, 2015
@joeljfischer
Copy link
Contributor

Duplicate of #223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
best practice Not a defect but something that should be improved anyway
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joeljfischer @justinjdickow