Adding AppInfo Struct to RegisterAppInterface #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er app interface.
…e_398_appinfo * smartdevicelink/develop: (84 commits) Fixed spec issue relating to changed default movementTimeThreshold. Fixed spec issues relating to changed protocol property name. Added check for singleTapTimer nullability when canceling. Removed external displayCapabilities property. Removed synthesize of videoEncoderSettings. Consolidated inits with a base init that both the deprecated and new init use. Updated SDLStreamingMediaManager's init function to include display capabilities. Moved the observing of application state changes to Streaming Media Manager. Moved Touch Manager to be a property of the Streaming Media Manager instead of the Proxy. Updated SDLPinchGesture's touches from having copy to strong. Added observation of when an application enters an invalidate state so we can end timers. Renamed internal methods to make them more readable. Added support for retrieving screen dimensions from a successful register app interface for use in the video encoder. Added nullable property to streaming media manager for proper cleanup when destructing the proxy. Changed videoEncoderSettings to be null_resettable instead of nullable, because that is essentially what we are doing. Removed surrounding parenthesis on NSNumber-wrapped boolean. Fixed issue with default movementTimeThreshold being off by a tenth resulting in no panning callbacks. add id attribute to section headers for linking Renamed touchEventListener to touchEventDelegate. Updated variable from "Listener" to "Delegate. ...
Current coverage is 29.09% (diff: 0.00%)@@ develop #431 diff @@
==========================================
Files 289 290 +1
Lines 9637 9669 +32
Methods 2643 2652 +9
Messages 0 0
Branches 632 633 +1
==========================================
Hits 2813 2813
- Misses 6779 6811 +32
Partials 45 45
|
|
@joeljfischer please review |
| SDLAppInfo* appInfo = [[SDLAppInfo alloc] init]; | ||
| NSBundle* mainBundle = [NSBundle mainBundle]; | ||
| NSDictionary* bundleDictionary = mainBundle.infoDictionary; | ||
| appInfo.appVersion = [bundleDictionary objectForKey:kBundleShortVersionStringKey]; |
There was a problem hiding this comment.
This can use shortened syntax: bundleDictionary[kBundleShortVersionStringKey].
|
@justinjdickow where is this on implementation into Core? |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #398
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Tests have been added to SDLRegisterAppInterfaceSpec and SDLRPCRequestFactorySpec and newly made SDLAppInfoSpec.
Summary
This PR adds the ability to send an app info struct with a register app interface to assist in remote app launching strategies.
Changelog
Enchancements