Touch Manager #423

asm09fsu · 2016-06-15T15:22:40Z

Fixes #402

This PR is ready for review.

Risk

This PR makes minor API changes.

Testing Plan

Tests need to be written to make sure that we are correctly calculating pinch, pan, single and double touches.

Summary

This PR introduces the Touch Manager, which is, simply, a wrapper around the onOnTouchEvent notification that we receive from Core. TM handles the logic for determining when a single or double tap has occurred, as well as panning and pinching. Some of these properties are changeable for the developer, but the main objective here is to develop a standard implementation so developers can focus on creating applications, not on logic to handle touching events.
The Touch Manager is only valid for applications utilizing video streaming.

For information on video streaming for mobile navigation, look at our reference here.

There are a few classes/structs/headers that have been added:

SDLTouchManager.h/m
- All logic for interpreting an onOnTouchEvent notification, and calling the SDLTouchManagerListener's protocol.
SDLTouchManagerListener.h
- The protocol callbacks used for informing a developer of touch events.
SDLTouch.h/m
- Struct for storing SDLTouchEvent in an easier to consumer manner, as well as some functions to assist in comparisons and validity.
SDLPinchGesture.h/m
- Struct for storing a pinch gesture, which is comprised of SDLTouch structs. This also contains functions for assisting in comparisons and validity.
CGPoint_Util.h/m
- Basic utility functions to assist in CGPoint calculations.
dispatch_timer.h/m
- Wrapper around dispatch queues for using a GCD timers.

Changelog

Enhancements

Added a touch manager for developers to easily add touch handling for video streaming applications.

Tasks Remaining:

Add Documentation
- SDLTouchManager
- CGPoint_Util
- SDLTouch
- SDLPinchGesture
Add Tests
- SDLTouchManager
- CGPoint_Util
- SDLTouch
- SDLPinchGesture
- dispatch_timer

…ifications.

codecov-io · 2016-06-15T16:42:44Z

Current coverage is 69.51% (diff: 74.64%)

Merging #423 into develop will increase coverage by 0.11%

@@            develop       #423   diff @@
==========================================
  Files           281        289     +8   
  Lines          9376       9589   +213   
  Methods        2585       2636    +51   
  Messages          0          0          
  Branches        603        623    +20   
==========================================
+ Hits           6507       6666   +159   
- Misses         2581       2618    +37   
- Partials        288        305    +17

Powered by Codecov. Last update 11b0b07...ec0262d

…alues.

… be easier for developers.

…1 for SDLTouchZero.

… Core, we will use device's timestamp.

…ers is minimal.

asm09fsu · 2016-06-29T00:22:40Z

@joeljfischer start reviewing the tests please when you get a chance.

joeljfischer · 2016-06-30T18:59:35Z

SmartDeviceLink/SDLTouchManagerListener.h

@@ -0,0 +1,25 @@
+//
+//  SDLTouchManagerListener.h


Listener is the Java convention I believe. It should be named -Delegate.

If that's the case, we should be modifying all other Protocols that use -Listener, I was simply trying to keep it consistent 👎

Oh yeah, definitely. It's just a breaking change to do so.

…esulting in no panning callbacks.

joeljfischer · 2016-07-28T13:24:31Z

We already know timers don't work properly in the background. Does the touch manager explicitly handle that case? For example, it could watch for background notifications and stop timers, watch for foreground and restart, but it would also have to notify the developer that it's not going to work in the background.

asm09fsu · 2016-07-28T14:11:12Z

Video streaming doesn't work in the background, so I don't think we really need to be concerned with the timers.

joeljfischer · 2016-07-28T15:02:15Z

SmartDeviceLink/SDLPinchGesture.h

+ *  @abstract
+ *      First touch of a pinch gesture.
+ */
+@property (nonatomic, copy) SDLTouch* firstTouch;


These aren't copyable, I don't think?

You're right! This was when we were using c-structs instead of objects.

…o we can end timers.

…nstead of the Proxy.

…anager.

joeljfischer · 2016-07-29T14:50:17Z

I'm seeing a few test failures after the changes

joeljfischer · 2016-07-29T18:47:02Z

LGTM

# Conflicts: # SmartDeviceLink/SDLStreamingMediaManager.h # SmartDeviceLink/SDLStreamingMediaManager.m

Initial support for a touch manager for interpreting onTouchEvent not…

ef3fe39

…ifications.

asm09fsu added the enhancement label Jun 15, 2016

asm09fsu added this to the 4.2 milestone Jun 15, 2016

asm09fsu added 2 commits June 15, 2016 09:07

Updated SDLTouchManager's header to public

80ba013

Added touch manager to SmartDeviceLink.h

17337c4

asm09fsu added 18 commits June 15, 2016 16:17

Fixed issue relating to using C files in cocoapods.

3ca1d55

Using ULONG_MAX instead of 0 for our unsigned longs in const struct v…

e704ce7

…alues.

Updated the tapTimeThreshold to be seconds instead of milliseconds to…

4e3c613

… be easier for developers.

Fixed function mistype.

0debf95

Added missing header for ULONG_MAX.

ca030ed

Added spec tests for CGPoint_Util.

e39aeaa

Updated SDLTouch to use a signed long for identifier, so we may use -…

5338b68

…1 for SDLTouchZero.

Added SDLTouch spec tests.

d26d4f9

Removed public exposure of SDLTouchEqualToTouch

23281cb

Added SDLPinchGesture spec tests.

de8db6e

Fixed SDLPinchGesture tests.

4564749

Added dispatch_timer spec tests.

ef754ee

removed unecessary @Class

116008b

Reduced pan time threshold to a lower value to improve panning delay.

8199fcf

Adding check in the event we receive an invalid timestamp object from…

ef7d601

… Core, we will use device's timestamp.

Made performingTouchType internal because necessity of it for develop…

301f21f

…ers is minimal.

Added multiple structs/notifications to be visible to testing target.

565d10f

Added tests for all touch events.

b11680b

joeljfischer reviewed Jun 30, 2016
View reviewed changes

asm09fsu added 7 commits July 17, 2016 15:21

Removed duplicate function.

4c7fc67

Removed unneeded function.

4696481

Added documentation

f822b52

Renamed SDLTouchManagerListener to SDLTouchManagerDelegate

34e4441

Updated variable from "Listener" to "Delegate.

37c3351

Renamed touchEventListener to touchEventDelegate.

adaa29e

Fixed issue with default movementTimeThreshold being off by a tenth r…

7dd3744

…esulting in no panning callbacks.

joeljfischer modified the milestones: 4.X, 4.2 Jul 27, 2016

Merge branch 'develop' into feature/touch_manager

32506bc

joeljfischer reviewed Jul 28, 2016
View reviewed changes

joeljfischer changed the title ~~[WIP] Touch Manager Support~~ Touch Manager Jul 28, 2016

asm09fsu added 6 commits July 28, 2016 08:50

Renamed internal methods to make them more readable.

a353f96

Added observation of when an application enters an invalidate state s…

977f7f4

…o we can end timers.

Updated SDLPinchGesture's touches from having copy to strong.

3dc4d5c

Moved Touch Manager to be a property of the Streaming Media Manager i…

e6b44e8

…nstead of the Proxy.

Moved the observing of application state changes to Streaming Media M…

9f0a635

…anager.

Added check for singleTapTimer nullability when canceling.

8d4b1b8

joeljfischer modified the milestones: 4.2, 4.X Jul 29, 2016

asm09fsu added 2 commits July 29, 2016 11:37

Fixed spec issues relating to changed protocol property name.

e17cda8

Fixed spec issue relating to changed default movementTimeThreshold.

10b8220

Merge branch 'develop' into feature/touch_manager

ca91918

# Conflicts: # SmartDeviceLink/SDLStreamingMediaManager.h # SmartDeviceLink/SDLStreamingMediaManager.m

joeljfischer merged commit ca91918 into develop Jul 29, 2016

joeljfischer deleted the feature/touch_manager branch July 29, 2016 19:15

joeljfischer mentioned this pull request Aug 3, 2016

Add Touch Manager for improved onTouchEvent Handling #402

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Touch Manager #423

Touch Manager #423

asm09fsu commented Jun 15, 2016 •

edited by joeljfischer

codecov-io commented Jun 15, 2016 •

edited

asm09fsu commented Jun 29, 2016

joeljfischer Jun 30, 2016

asm09fsu Jun 30, 2016

joeljfischer Jun 30, 2016

joeljfischer commented Jul 28, 2016

asm09fsu commented Jul 28, 2016

joeljfischer Jul 28, 2016

asm09fsu Jul 28, 2016

joeljfischer commented Jul 29, 2016

joeljfischer commented Jul 29, 2016

Touch Manager #423

Touch Manager #423

Conversation

asm09fsu commented Jun 15, 2016 • edited by joeljfischer

Risk

Testing Plan

Summary

Changelog

Enhancements

Tasks Remaining:

codecov-io commented Jun 15, 2016 • edited

Current coverage is 69.51% (diff: 74.64%)

asm09fsu commented Jun 29, 2016

joeljfischer Jun 30, 2016

Choose a reason for hiding this comment

asm09fsu Jun 30, 2016

Choose a reason for hiding this comment

joeljfischer Jun 30, 2016

Choose a reason for hiding this comment

joeljfischer commented Jul 28, 2016

asm09fsu commented Jul 28, 2016

joeljfischer Jul 28, 2016

Choose a reason for hiding this comment

asm09fsu Jul 28, 2016

Choose a reason for hiding this comment

joeljfischer commented Jul 29, 2016

joeljfischer commented Jul 29, 2016

asm09fsu commented Jun 15, 2016 •

edited by joeljfischer

codecov-io commented Jun 15, 2016 •

edited