Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SDLVideoError enum name #411

Merged
merged 2 commits into from Jul 28, 2016
Merged

Fix SDLVideoError enum name #411

merged 2 commits into from Jul 28, 2016

Conversation

joeljfischer
Copy link
Contributor

@joeljfischer joeljfischer commented May 27, 2016

Fixes #383

This PR is ready for review.

Risk

This PR makes minor API changes.

Summary

This PR adds a new enum with the same value as the previous, now deprecated value. SDLStreamingVideoError SDLSTreamingVideoErrorInvalidOperatingSystemVersion is updated as SDLStreamingVideoErrorInvalidOperatingSystemVersion.

Changelog

Bug Fixes
  • Update SDLVideoError enum with a fixed enum name and deprecate the old one.

@joeljfischer joeljfischer added the bug A defect in the library label May 27, 2016
@joeljfischer joeljfischer added this to the 4.2 milestone May 27, 2016
@joeljfischer joeljfischer changed the title Hotfix/issue 383 Fix SDLVideoError enum name May 27, 2016
@codecov-io
Copy link

Current coverage is 69.40% (diff: 100%)

Merging #411 into develop will not change coverage

@@            develop       #411   diff @@
==========================================
  Files           281        281          
  Lines          9376       9376          
  Methods        2585       2585          
  Messages          0          0          
  Branches        603        603          
==========================================
  Hits           6507       6507          
  Misses         2581       2581          
  Partials        288        288          

Powered by Codecov. Last update 11b0b07...be56258

@joeljfischer
Copy link
Contributor Author

@asm09fsu can you do a 2 second review on this?

@asm09fsu
Copy link
Contributor

@joeljfischer LGTM 👍

@joeljfischer joeljfischer merged commit 42a69db into develop Jul 28, 2016
@joeljfischer joeljfischer deleted the hotfix/issue_383 branch July 28, 2016 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants