New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video Encoder Support for Dynamic Screen Sizes #400
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e screen size returned from a successful Register App Interface.
asm09fsu
added
enhancement
best practice
Not a defect but something that should be improved anyway
labels
May 17, 2016
@@ -36,7 +36,7 @@ typedef void (^SDLStreamingStartBlock)(BOOL success, NSError *__nullable error); | |||
|
|||
@interface SDLStreamingMediaManager : NSObject <SDLProtocolListener> | |||
|
|||
- (instancetype)initWithProtocol:(SDLAbstractProtocol *)protocol; | |||
- (instancetype)initWithProtocol:(SDLAbstractProtocol *)protocol displayCapabilities:(SDLDisplayCapabilities*)displayCapabilities; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a major version change.
…ty properties. Also added nil when proxy is disposed for local display capabilities.
This can still make a minor release before EF if it's updated to not have conflicts and to fix the major version change |
* origin/master: (30 commits) add id attribute to section headers for linking Add link to smartdevicelink.com to README Update for v4.1.4 Fix not handling the TCP disconnect case Update README.md Update README.md Add documentation coverage badge to README Fix `.xctool-args` path to project Fix another codecov.yml issue Fix branch issue for codecov comments Basically just a bump to re-run tests Update for v4.1.3 Add clean switch to generate-documentation.sh Update gen documentation script Add Jazzy theme, scripts, initial documentation, and an updated gitignore Update codecov yaml file comment and status settings Fix mis-spaced README file causing header issues Fix test script Add carthage before_deploy generating of archive Fix a badge in the README ...
Current coverage is 69.31% (diff: 0.00%)@@ master #400 diff @@
==========================================
Files 281 281
Lines 9376 9387 +11
Methods 2585 2587 +2
Messages 0 0
Branches 603 605 +2
==========================================
Hits 6507 6507
- Misses 2581 2592 +11
Partials 288 288
|
This has been included in PR #406 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #399
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
We can test by starting a video session and validating that the encoder is in fact using the screen dimensions returned back from a register app interface response.
Summary
Added support for
SDLStreamingMediaManager
's initializer to use the screen dimensions returned from a successful RegisterAppInterface.Changelog
Enchancements
SDLStreamingMediaManager
's initializer to use the screen dimensions returned from a successful RegisterAppInterface.