Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video Encoder Should Not Use Constant Values #399

Closed
asm09fsu opened this issue May 17, 2016 · 1 comment
Closed

Video Encoder Should Not Use Constant Values #399

asm09fsu opened this issue May 17, 2016 · 1 comment
Labels
best practice Not a defect but something that should be improved anyway
Milestone
4.6.0

Comments

@asm09fsu
Copy link
Contributor

Bug Report

Currently SDLStreamingMediaManager's video encoder uses static values for width and height. We should be using values from the RegisterAppInterface Response.

Expected Behavior

Video Encoder uses values from the RegisterAppInterface Response when building encoder.

Observed Behavior

Video Encoder uses static values when building encoder.

OS & Version Information
  • iOS Version: 9.3.2
  • SDL iOS Version: 4.1.1
@asm09fsu asm09fsu added enhancement best practice Not a defect but something that should be improved anyway labels May 17, 2016
@asm09fsu asm09fsu added this to the 4.1.X milestone May 17, 2016
@asm09fsu asm09fsu mentioned this issue May 17, 2016
Closed
@asm09fsu asm09fsu mentioned this issue Jul 27, 2016
Closed
@asm09fsu
Copy link
Contributor Author

Merged in PR #406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
best practice Not a defect but something that should be improved anyway
Projects
None yet
Milestone
4.6.0
Development

No branches or pull requests
1 participant
@asm09fsu