New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Developer API Enhancements Phase 1 #298
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, it looks like there's some unnecessary autorelease pools that I forgot to remove. I'll fix them in another commit. |
Notes from Aaron from our previous convo:
|
* Configuration options for lock screen * Configuration options for TCP debug * SDLManager implement the lock screen icon callback and store the image
* Didn't test lol 👻
… to be higher res than the appIcon
* Import SDLNotificationConstants to SDLManager.h so that when sending RPCs, you get correct Xcode completion
* Added delete and upload methods with completion handlers * Add a file wrapper "struct" to contain a file and it's completion handler * Remote files array is now mutable * Add a currentFileUploadOffset property for large file uploads * Upload queue now has a constraint * State is now handled a little differently and affects a few parts * Fix not doing weak/strongself where necessary
…nhappy with it's testability
* SDLLifecycleManager fixed “lastCorrelationId” actually giving the next correlation id * SDLLifecycleManager fixed sometimes dispatching delegates on main queue, sometimes not. Now where the delegate is called is arbitrary * Another batch of SDLLifecycleManagerSpec tests
* Add asserts in notification handlers if the object isn’t what we expect, just return out in production
* Add white and black sdl logos * Add code to use the correct white / black logo on the right background color
* Alter the default lock screen background color to SDL Dark Grey. * Add documentation around the lock screen configuration
* “voiceRecognitionSynonyms” -> “voiceRecognitionCommandNames” * Some properties are now readonly * Remove initial display layout since that will be the domain of a different set of code eventually
* Fix not connecting again because of VR synonyms being sent empty * Fix default background color not being used because Obj-C * SDLLifecycleConfiguration’s voiceRecognitionCommandNames can now be sent empty, and will be sent empty by default * Changed the name of the SDL Example app so that it won’t be truncated * Removed an unused property from the example app’s ProxyManager class
* Add FBSnapshotTests via Carthage, add license to DEPENDENCIES.md
* Example app now sets its app icon * SiphonServer analysis failures commented out
* Add a registerAppInterface property on SDLManager for now I guess ugh
* Fix SDLRPCRequestFactory tests throwing warnings because they’re testing deprecated methods. * Fix SDLLifecycleManager tests erroring on no longer extant properties. * Work around SDLLifecycleManager tests erroring because the RAI response comes inline instead of on a method callback. * Fix SmartDeviceLink.h erroring because some files don’t exist publicly and some do that did and did not before, respectively. * SDLLifecycleManager now manually imports each class it uses instead of all classes. * Removed old properties on SDLLifecycleManager and fix a public / private mismatch on hmiLevel probably causing them not to fire delegate callbacks. * Stub the hmiLevel delegate callback on the example project. * Add new tests for calling the hmiLevel SDLManagerDelegate callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@joeljfischer has taken over this post 😄
Fixes #223, #241
This post was last rewritten on 2016/07/27.
Not Ready For Merge
This adds a new high-level abstraction layer on top of the current SDL layers such as SDLProxy. When 5.0 rolls around, many of those old layers will be removed and the functionality will be hidden behind the new high level layers being added here. Additional functionality will be built on top of the new developer api for quicker and more intuitive SDL use.
Features included:
To-Do:
To Test: