Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy allows attempting to send an RPC when not connected #241

Closed
joeljfischer opened this issue Jun 19, 2015 · 3 comments
Closed

Proxy allows attempting to send an RPC when not connected #241

joeljfischer opened this issue Jun 19, 2015 · 3 comments
Labels
bug A defect in the library
Milestone

Comments

@joeljfischer
Copy link
Contributor

See #238

@adein
Copy link

adein commented Jun 19, 2015

If this could be fixed as a hotfix, it would be another one I'd like to get in ASAP if possible. It allows developers to create apps that will never be able to reconnect to SYNC until they are terminated and relaunched. At the same time, it's not easy for devs to root-cause the connection issue.

If we're only making it so that the proxy uses a BOOL to track connection state and prevent sending an RPC when not connected, I think it should be a pretty easy/quick change.

@joeljfischer
Copy link
Contributor Author

Yeah, probably a BOOL within the sendRPC: method of SDLProxy would be sufficient. The proxy isn't currently set up to know whether or not it's connected because it's assumed to be destroyed if not connected however, so that would be a bit of a change to make that work well.

@adein
Copy link

adein commented Jun 22, 2015

In my testing, I made a class BOOL (readonly public, readwrite private), that gets updated in the onProxyClosed / onProxyOpened events before the proxy listener delegate is called.

@justinjdickow justinjdickow modified the milestones: 4.0.0, 4.0.1 Jul 31, 2015
@joeljfischer joeljfischer modified the milestones: 4.1.0, 4.0.0 Oct 5, 2015
@joeljfischer joeljfischer modified the milestones: 4.3, 4.X Jul 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library
Projects
None yet
Development

No branches or pull requests

3 participants