Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Swift example app to use a non-deprecated SDLConfiguration #1607

Closed
NicoleYarroch opened this issue Mar 30, 2020 · 0 comments
Closed

Update the Swift example app to use a non-deprecated SDLConfiguration #1607

NicoleYarroch opened this issue Mar 30, 2020 · 0 comments
Labels
best practice Not a defect but something that should be improved anyway example app Relating to the built-in example apps
Projects
v6.6.0

Comments

@NicoleYarroch
Copy link
Contributor

Bug Report

The Swift example app uses a deprecated SDLConfiguration init in setupManagerConfiguration: in ProxyManager.swift

Reproduction Steps
  1. Open and build the library's Swift example app in Xcode
Expected Behavior

There are no buildtime warnings.

Observed Behavior

There is a buildtime warning

OS & Version Information
  • iOS Version: n/a
  • SDL iOS Version:6.5
  • Testing Against: n/a
@NicoleYarroch NicoleYarroch added best practice Not a defect but something that should be improved anyway example app Relating to the built-in example apps labels Mar 30, 2020
@NicoleYarroch NicoleYarroch mentioned this issue Mar 31, 2020
Merged
4 tasks
@joeljfischer joeljfischer added this to Waiting for Review in v6.6.0 Apr 6, 2020
v6.6.0 automation moved this from Waiting for Review to Done Apr 6, 2020
@joeljfischer joeljfischer mentioned this issue Apr 29, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
best practice Not a defect but something that should be improved anyway example app Relating to the built-in example apps
Projects
No open projects
v6.6.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joeljfischer @NicoleYarroch