Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When sending raw data, the library sets the same mtu size for every service type #1577

Closed
NicoleYarroch opened this issue Mar 5, 2020 · 0 comments
Assignees
Labels
bug A defect in the library protocol Relating to the protocol layer
Projects

Comments

@NicoleYarroch
Copy link
Contributor

Bug Report

When sending raw data, the library sets the same mtu size for every service type. However, since we get and save the mtu size for video and audio services, we should retrieve the correct mtu size for the service type.

Reproduction Steps

In the SDLProtocol class, thesdl_sendRawData:onService:encryption: method retrieves the mtuSizeForServiceType using the SDLServiceTypeRPC. However we send video and audio data using this same method. Instead of using SDLServiceTypeRPC to get the mtu size, we should use the passed service.

Observed Behavior

The production head units that I have tested with use the same mtu size for RPC, video, and audio services, however this may not aways be the case in the future or on other production head units.

OS & Version Information
  • iOS Version: n/a
  • SDL iOS Version: 6.5
  • Testing Against: n/a
@NicoleYarroch NicoleYarroch added the bug A defect in the library label Mar 5, 2020
@joeljfischer joeljfischer added this to To do in v6.6.0 Mar 18, 2020
@joeljfischer joeljfischer added the protocol Relating to the protocol layer label Mar 18, 2020
v6.6.0 automation moved this from To do to Done Apr 1, 2020
@joeljfischer joeljfischer mentioned this issue Apr 29, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library protocol Relating to the protocol layer
Projects
No open projects
v6.6.0
  
Done
Development

No branches or pull requests

3 participants