Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to handle subsequent video start service ACKs not setting the video resolution height and width #1561

Closed
NicoleYarroch opened this issue Feb 20, 2020 · 1 comment
Assignees
Labels
bug A defect in the library transport-secondary Relating to the secondary transport
Projects

Comments

@NicoleYarroch
Copy link
Contributor

Bug Report

The first video start service ACK received from Core always has the video resolution in the payload. However subsequent video start service ACKs during the same session sometimes set the video resolution to {0, 0}. This is an issue with the streaming video using TCP socket as a secondary transport as the video session must be destroyed when the app on the device is backgrounded and resumed when the app on the device is foregrounded. Currently the library assumes that the video start service ACK always returns the resolution in the payload so if {0, 0} is returned video can not stream due to the video encoder rejecting 0 as a dimension.

Reproduction Steps
  1. Connect a video streaming app with secondary transports enabled to a head unit that supports secondary transports for video streaming. Launch the SDL app if necessary and wait for video to start streaming.
  2. Put the app in the background.
  3. Bring the app to the foreground.
Expected Behavior

Video resumes.

Observed Behavior

Video does not resume due to the video start service ACK returning a resolution of {0, 0} in the payload.

OS & Version Information
  • iOS Version: 13
  • SDL iOS Version: 6.5
  • Testing Against: SYNC 4
@NicoleYarroch NicoleYarroch added bug A defect in the library transport-secondary Relating to the secondary transport labels Feb 20, 2020
@NicoleYarroch NicoleYarroch self-assigned this Feb 21, 2020
@joeljfischer joeljfischer added this to To do in v6.6.0 Mar 18, 2020
@NicoleYarroch
Copy link
Contributor Author

Fixed in PR #1566

v6.6.0 automation moved this from To do to Done Apr 1, 2020
@joeljfischer joeljfischer mentioned this issue Apr 29, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library transport-secondary Relating to the secondary transport
Projects
No open projects
v6.6.0
  
Done
Development

No branches or pull requests

1 participant