Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Swift example app logic for checking the first time that the hmiLevel is FULL is broken #1554

Closed
NicoleYarroch opened this issue Feb 10, 2020 · 3 comments
Assignees
Labels
bug A defect in the library example app Relating to the built-in example apps
Projects

Comments

@NicoleYarroch
Copy link
Contributor

Bug Report

The Swift example app code for finding the first time that the hmiLevel is FULL is broken as the following code never gets called in the ProxyManager class:

if newLevel == .full && firstHMILevelState != .full {
    // This is our first time in a `FULL` state.
    firstHMILevelState = newLevel
}

This logic doesn't seem to be in the Obj-C example app so it either the logic needs to get fixed in both example apps or removed from the Swift example app.

Reproduction Steps
  1. Connect Swift example app to a head unit.
Expected Behavior

The code above should be called the very first time the hmiLevel is FULL.

Observed Behavior

The code above is never called.

OS & Version Information
  • iOS Version: n/a
  • SDL iOS Version: 6.5
  • Testing Against: SYNC 4
@NicoleYarroch NicoleYarroch added bug A defect in the library example app Relating to the built-in example apps labels Feb 10, 2020
@lapinskijw
Copy link
Contributor

@NicoleYarroch Unless there is a best practice we should be including here regarding first hmiLevel FULL I believe it would be best to remove the code for a couple reasons.

  1. As you said, this logic is not in the Obj-C example app.
  2. The only action this code accomplishes is setting the fristHMILevelState to full, which occurs in hmiLevel:didChangeToLevel:.

@NicoleYarroch
Copy link
Contributor Author

@lapinskijw I agree with removing the code from the Swift app based on the situations you outlined.

@theresalech
Copy link
Contributor

Closed via #1574

@theresalech theresalech added this to Done in v6.6.0 via automation Mar 10, 2020
@joeljfischer joeljfischer mentioned this issue Apr 29, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library example app Relating to the built-in example apps
Projects
No open projects
v6.6.0
  
Done
Development

No branches or pull requests

3 participants