Dismiss LockViewController not always completed

[kshala-ford]

Bug Report

This is a regression since 6.5.0. With 6.5.0 the lock screen presenter has changed. The logic to dismiss a lock screen is triggered for many different reasons e.g. manager connects or app gets to foreground on the phone. See SDLLockScreenPresenter.m:168. Every dismiss attempt sends a SDLLockScreenManagerWillDismissLockScreenViewController notification. However if the lock screen is not presented, the notification SDLLockScreenManagerDidDismissLockScreenViewController is missing. The latter one is important for SDLCarWindow to operate as it's tracking lockscreen transitions. The consequence is that mobile navigation apps don't project the UI as the car window is early returning in syncFrame see SDLCarWindow.m:70.

To solve the issue the lock screen presenter should not send notifications if LockViewController is not presented. See below snippet that I tested right before the notification solved the problem for me.

    if (self.lockViewController.presentingViewController == nil) {
        SDLLogW(@"Attempted to dismiss lockscreen, but lockViewController is not presented");
        if (completionHandler == nil) { return; }
        return completionHandler();
    }

Reproduction Steps

1. Install mobile navigation app with sdl_ios 6.5.0
2. Connect iPhone to an IVI
3. Start the nav app on the phone
4. Start the nav app on the IVI

Expected Behavior

The nav app should stream the app UI to the IVI

Observed Behavior

The IVI is waiting for the app to start the stream

• The CarWindow is ignoring syncFrame calls

OS & Version Information

• iOS Version: 13.3 (reproduced on 13.2 as well)
• SDL iOS Version: 6.5.0
• Testing Against: Proprietary app. Can provide access upon request