Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Show RPC's templateConfiguration parameter is not set #1486

Closed
NicoleYarroch opened this issue Dec 4, 2019 · 0 comments
Closed

The Show RPC's templateConfiguration parameter is not set #1486

NicoleYarroch opened this issue Dec 4, 2019 · 0 comments
Assignees
Labels
bug A defect in the library

Comments

@NicoleYarroch
Copy link
Contributor

Bug Report

The Show RPC's templateConfiguration parameter is not set in the correct dictionary and thus can not be retrieved.

It should be stored in the parameters dictionary and not the store dictionary like so:

- (void)setTemplateConfiguration:(nullable SDLTemplateConfiguration *)templateConfiguration {
    [self.parameters sdl_setObject:templateConfiguration forName:SDLRPCParameterNameTemplateConfiguration];
}

- (nullable SDLTemplateConfiguration *)templateConfiguration {
    return [self.parameters sdl_objectForName:SDLRPCParameterNameTemplateConfiguration ofClass:SDLTemplateConfiguration.class error:nil];
}

Test cases for the templateConfiguration and the windowID should be added to the SDLShowSpec.

Reproduction Steps
  1. Create a SDLShow request and set the templateConfiguration parameter.
  2. Send the SDLShow request.
Expected Behavior

The templateConfiguration parameter is set in the Show request sent to core.

Observed Behavior

The templateConfiguration parameter is not set in the Show request sent to core.

OS & Version Information
  • iOS Version: n/a
  • SDL iOS Version: 6.4.1
  • Testing Against: n/a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library
Projects
None yet
Development

No branches or pull requests

2 participants