Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the SDLAsynchronousOperation to return a boolean from the start method #1379

Closed
NicoleYarroch opened this issue Aug 9, 2019 · 1 comment
Closed

Refactor the SDLAsynchronousOperation to return a boolean from the start method #1379

NicoleYarroch opened this issue Aug 9, 2019 · 1 comment
Assignees
@joeljfischer
Labels
best practice Not a defect but something that should be improved anyway
Projects
v6.4
Milestone
6.4.0

Comments

@NicoleYarroch
Copy link
Contributor

Refactor the SDLAsynchronousOperation to return a BOOL from start and returning in our subclass start methods. If the operation has not been cancelled, return true, otherwise return false.

We have 13 classes that subclass SDLAsynchronousOperation so all would have to be updated.
@NicoleYarroch NicoleYarroch added the best practice Not a defect but something that should be improved anyway label Aug 9, 2019
@NicoleYarroch NicoleYarroch added this to the Future milestone Aug 9, 2019
@joeljfischer joeljfischer mentioned this issue Sep 19, 2019
Merged
2 tasks
@NicoleYarroch
Copy link
Contributor Author

Fixed in PR #1403

@NicoleYarroch NicoleYarroch added this to To do in v6.4 via automation Sep 23, 2019
@NicoleYarroch NicoleYarroch modified the milestones: Future, 6.4.0 Sep 23, 2019
@theresalech theresalech moved this from To do to Done in v6.4 Sep 25, 2019
@joeljfischer joeljfischer mentioned this issue Oct 24, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joeljfischer joeljfischer

Labels
best practice Not a defect but something that should be improved anyway
Projects
No open projects
v6.4
  
Done
Milestone
6.4.0
Development

No branches or pull requests
2 participants
@joeljfischer @NicoleYarroch