Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash after the failure of iAP data session creation #1321

Closed
t-yoshii opened this issue Jun 26, 2019 · 0 comments
Closed

Crash after the failure of iAP data session creation #1321

t-yoshii opened this issue Jun 26, 2019 · 0 comments
Assignees
Labels
bug A defect in the library
Projects
Milestone

Comments

@t-yoshii
Copy link

Bug Report

Crash happens after the failure of iAP data session creation due to assertion check failure.

Even createSession in SDLIAPDataSession#startSession failed including retry (3 times), [self.ioStreamThread start];is called, this causes assertion failure at https://github.com/smartdevicelink/sdl_ios/blob/develop/SmartDeviceLink/SDLIAPDataSession.m#L322

Jun 21 18:03:37 iPhoneXS-M00326 CTSLang(ExternalAccessory)[323] <Notice>: ERROR - opening session failed
 :
Jun 21 18:03:37 iPhoneXS-M00326 CTSLang(SmartDeviceLink)[323] <Notice>: 18:03:37:448 \M-b\M^Z\M-* VERBOSE com.sdl.lifecycle (SDL)Transport:SDLIAPTransport:-[SDLIAPTransport dataSessionShouldRetry]:415 - Retrying the data session
 :
// Failed 3 times
Jun 21 18:03:37 iPhoneXS-M00326 CTSLang(SmartDeviceLink)[323] <Notice>: 18:03:37:448 \M-p\M^_\M^T\M-6 WARNING com.sdl.lifecycle (SDL)Transport:SDLIAPTransport:-[SDLIAPTransport sdl_establishSessionWithAccessory:]:356 - Surpassed allowed retry attempts (3), dismissing setup

Jun 21 18:03:37 iPhoneXS-M00326 CTSLang(Foundation)[323] <Notice>: *** Assertion failure in -[SDLIAPDataSession sdl_accessoryEventLoop], ...../SmartDeviceLink/SDLIAPDataSession.m:325

Jun 21 18:03:37 iPhoneXS-M00326 CTSLang(CoreFoundation)[323] <Notice>: *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Session must be assigned before calling'
*** First throw call stack:
(0x200f223a8 0x200127d00 0x200e37780 0x20191232c 0x1050929a4 0x20188ac4c 0x2019c0e54 0x200b2a908 0x200b2a864 0x200b32dcc)
Jun 21 18:03:37 iPhoneXS-M00326 CTSScreensApp_ms(Foundation)[325] <Notice>: *** Assertion failure in -[SDLIAPDataSession sdl_accessoryEventLoop], ...../SmartDeviceLink/SDLIAPDataSession.m:325
Reproduction Steps
  1. EA data session creation failed for some reason.
Expected Behavior
  1. SDLIAPTransport just stops retrying the session creation.
Observed Behavior
  1. App crashes
OS & Version Information

iOS Version: iOS11, 12
SDL iOS Version: develop branch daa57de (6.2.3 +)
Testing Against: Our internal devboard/OEM HU

Test Case, Sample Code, and / or Example App

I will create PR

@NicoleYarroch NicoleYarroch added the bug A defect in the library label Jun 26, 2019
@NicoleYarroch NicoleYarroch added this to To do in v6.3 via automation Jun 26, 2019
@NicoleYarroch NicoleYarroch added this to the 6.3.0 milestone Jun 26, 2019
v6.3 automation moved this from To do to Done Jun 26, 2019
@joeljfischer joeljfischer mentioned this issue Jun 26, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library
Projects
No open projects
v6.3
  
Done
Development

No branches or pull requests

3 participants