Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accepted with Revisions] SDL 0237 - Add Feature to Disable "Video Streaming Backgrounded String" Feature #753

Closed
theresalech opened this issue Jun 5, 2019 · 5 comments

Comments

@theresalech
Copy link
Contributor

theresalech commented Jun 5, 2019

Hello SDL community,

The review of "SDL 0237 - Add Feature to Disable "Video Streaming Backgrounded String" Feature" begins now and runs through June 11, 2019. The proposal is available here:

https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0237-add-feature-to-disable-video-streaming-backgrounded-string-feature.md

Reviews are an important part of the SDL evolution process. All reviews should be sent to the associated Github issue at:

#753

What goes into a review?

The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of SDL. When writing your review, here are some questions you might want to answer in your review:

  • Is the problem being addressed significant enough to warrant a change to SDL?
  • Does this proposal fit well with the feel and direction of SDL?
  • If you have used competitors with a similar feature, how do you feel that this proposal compares to those?
  • How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
    Please state explicitly whether you believe that the proposal should be accepted into SDL.

More information about the SDL evolution process is available at

https://github.com/smartdevicelink/sdl_evolution/blob/master/process.md

Thank you,
Theresa Lech

Program Manager - Livio
theresa@livio.io

@joeljfischer
Copy link
Contributor

I'm in favor of this proposal, however I think that sendVideoBackgroundedString should be renamed to showVideoBackgroundDisplay.

@t-yoshii
Copy link
Contributor

Hello @joeljfischer ,

Thanks for your comments.

sendVideoBackgroundedString should be renamed to showVideoBackgroundDisplay

I think it is good too.

@theresalech theresalech changed the title [In Review] SDL 0237 - Add Feature to Disable "Video Streaming Backgrounded String" Feature [Accepted with Revisions] SDL 0237 - Add Feature to Disable "Video Streaming Backgrounded String" Feature Jun 12, 2019
@theresalech
Copy link
Contributor Author

The Steering Committee voted to accept this proposal with the following revision: rename sendVideoBackgroundedString to showVideoBackgroundDisplay.

@theresalech
Copy link
Contributor Author

@t-yoshii please advise when a new PR has been entered to update the proposal to reflect the agreed upon revision. I'll then merge the PR so the proposal is up to date, and submit an issue in the iOS repository for implementation. Thanks!

@smartdevicelink smartdevicelink locked and limited conversation to collaborators Jun 12, 2019
@theresalech
Copy link
Contributor Author

Proposal has been updated to reflect revision, and implementation issue has been entered: smartdevicelink/sdl_ios#1304.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants