New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Accepted] SDL 0115 - CloseApplication RPC #351
Comments
I have a few questions about the purpose of this proposed RPC. The motivation states:
This seems perhaps to conflict in usefulness with a second in-progress proposal: In-Progress RPC. If the app can just open the menu, then they wouldn't need their own menu, and they wouldn't need the ability to close their app. Second, is this something that will be enforced that apps must add to their menu? If not, I can't see very many apps actually adding a button that exits their app. I think it could be enforced, but I think the other way of solving this problem (enforcing that apps have a button to show the menu as seen in the other proposal) is a better way to solve the problem. |
I think this proposal is is similar to SDL 0116 - Open Menu RPC and that both cases could be solved by the use of a single RPC instead of each case having their own. We could maybe create an RPC called
To Close app To Show app menu |
I like @JackLivio's suggestion quite a bit. |
Many of the hmiLevel and systemContext values don't make sense as settable values by a connected app; providing this much flexibility when only a couple of permutations are actually valid seems like it could be confusing. |
Although I like the idea of using already defined API I agree to @NickFromAmazon. It might be confusing and cause more effort in checks for invalid values. At the end it looks much more complex to be implemented. Changing the HMI level is a sensitive task. Apps might want to be abel to move to
Generally this proposal does not conflict with OpenMenu RPC. Both proposals could coexist and solve problems with apps who want to use the built-in menu and those who don't (we have both kinds of apps).
|
The Steering Committee voted to accept this proposal. |
Hello SDL community,
The review of "CloseApplication RPC" begins now and runs through November 28, 2017. The proposal is available here:
https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0115-close-application.md
Reviews are an important part of the SDL evolution process. All reviews should be sent to the associated Github issue at:
#351
What goes into a review?
The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of SDL. When writing your review, here are some questions you might want to answer in your review:
Please state explicitly whether you believe that the proposal should be accepted into SDL.
More information about the SDL evolution process is available at
https://github.com/smartdevicelink/sdl_evolution/blob/master/process.md
Thank you,
Theresa Lech
Program Manager - Livio
theresa@livio.io
The text was updated successfully, but these errors were encountered: