Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accepted] SDL 0108 - AutoCompleteList #331

Closed
theresalech opened this issue Nov 8, 2017 · 4 comments
Closed

[Accepted] SDL 0108 - AutoCompleteList #331

theresalech opened this issue Nov 8, 2017 · 4 comments

Comments

@theresalech
Copy link
Contributor

theresalech commented Nov 8, 2017

Hello SDL community,

The review of "AutoCompleteList" begins now and runs through November 14, 2017. The proposal is available here:

https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0108-AutoCompleteList.md

Reviews are an important part of the SDL evolution process. All reviews should be sent to the associated Github issue at:

#331

What goes into a review?

The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of SDL. When writing your review, here are some questions you might want to answer in your review:

  • Is the problem being addressed significant enough to warrant a change to SDL?
  • Does this proposal fit well with the feel and direction of SDL?
  • If you have used competitors with a similar feature, how do you feel that this proposal compares to those?
  • How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
    Please state explicitly whether you believe that the proposal should be accepted into SDL.

More information about the SDL evolution process is available at

https://github.com/smartdevicelink/sdl_evolution/blob/master/process.md

Thank you,
Theresa Lech

Program Manager - Livio
theresa@livio.io

@Jack-Byrne
Copy link
Contributor

How often would "SetGlobalProperties" be sent from the phone? Does core notify the phone after every keyboard press so the phone knows the context of how to generate the autoCompleteList sent in setGlobalProperties?

If that is not the case, then is size 100 of the array enough possible words to be useful?

@joeljfischer
Copy link
Contributor

@JackLivio It would be sent after every keypress, and yes, Core notifies the phone with OnKeyboardInput after each keypress.

@theresalech theresalech changed the title [In Review] SDL 0108 - AutoCompleteList [Accepted] SDL 0108 - AutoCompleteList Nov 15, 2017
@theresalech
Copy link
Contributor Author

The Steering Committee voted to accept this proposal.

@smartdevicelink smartdevicelink locked and limited conversation to collaborators Nov 15, 2017
@theresalech
Copy link
Contributor Author

theresalech commented Nov 16, 2017

Issues Entered:
Core
iOS
Android
RPC
sdl_hmi

@theresalech theresalech added the hmi label Jul 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants