Sometimes SDL does not reset timeout for DiagnosticMessage response by receiving 2nd BC.OnResetTimeout' notification

[VjKlepikov]

Bug Report

Sometimes SDL does not reset timeout for DiagnosticMessage response by receiving 2nd BC.OnResetTimeout' notification

Occurrences: ~0.1%

Reproduction Steps

1. Default SDL timeout is 10s (defined in .INI by 'DefaultTimeout' parameter)
2. App is registered
3. App sends DiagnosticMessage request
4. SDL transfers this request to HMI
5. HMI sends 1st 'BC.OnResetTimeout' notification to SDL right after receiving request with 'resetPeriod=15s'
6. HMI sends 2nd 'BC.OnResetTimeout' notification to SDL after delay of 12s with 'resetPeriod=7s'
7. HMI doesn't provide a response

Expected Behavior

SDL wait for the response from HMI within 'delay + 2nd resetPeriod' (19s)
respond with GENERIC_ERROR:false to Mobile app once this timeout expires

Observed Behavior

SDL does not reset timeout for DiagnosticMessage response by receiving 2nd BC.OnResetTimeout' notification
respond with GENERIC_ERROR:false to Mobile app once timeout expires (15s) after first request

OS & Version Information

• OS/Version: Ubuntu 18
• SDL Core Version: https://github.com/smartdevicelink/sdl_core/tree/release/8.1.0 (b30f012) (also reproduced in 8.0.0)

Test Case, Sample Code, and / or Example App

./test_scripts/API/Restructuring_OnResetTimeout/005_BC_OnResetTimeout_HMI_sends_notification_twice.lua

Logs

Log.tar.gz